Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeQualityStrict] Allow MoveVariableDeclarationNearReferenceRector to pass static call on Throwable instance #5999

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Mar 26, 2021

Throwable instance with static call mostly used for named constructor call, eg:

throw MyException::notFound();

which usually not change external data. This allow to pass it to move variable after it.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit 58a0965 into main Mar 29, 2021
@TomasVotruba TomasVotruba deleted the allow-move-variable-dec-static-throwable branch March 29, 2021 08:27
@TomasVotruba
Copy link
Member

Thank you 👍

TomasVotruba added a commit that referenced this pull request Jun 21, 2024
rectorphp/rector-src@657bf47 [ci] Remove composer unused, as surpassed by dependency analyser (#5999)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants